{zones} new resource types & bugfix - version 1.0.0b4#8820
{zones} new resource types & bugfix - version 1.0.0b4#8820zhoxing-ms merged 4 commits intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Greedygre,
JennyLawrance,
Juliehzl,
chinadragon0515,
ebencarek,
howang-ms,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto,
vturecek,
wangzelin007,
yanzhudd,
yonzhan and
zhoxing-ms
There was a problem hiding this comment.
Pull Request Overview
This PR prepares the 1.0.0b4 release by normalizing resource group input, adding zone-validation for new resource types, bumping the extension version, and updating docs/history.
- Force resource group names to lowercase for ARG comparisons
- Add zone-redundancy checks for NAT Gateways, Public IP Prefixes, and Container App Jobs
- Bump version to 1.0.0b4; update README and release history
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/zones/setup.py | Bump extension version to 1.0.0b4 |
| src/zones/azext_zones/resource_type_validators/microsoft_network.py | Add validators for NAT Gateways and Public IP Prefixes |
| src/zones/azext_zones/resource_type_validators/microsoft_app.py | Add validator for Container App Jobs |
| src/zones/azext_zones/_argHelper.py | Lowercase resource group input for ARG query |
| src/zones/README.md | Note that tags are case-sensitive |
| src/zones/HISTORY.rst | Document new 1.0.0b4 release items |
Comments suppressed due to low confidence (3)
src/zones/azext_zones/resource_type_validators/microsoft_network.py:71
- No unit tests cover the new
natgatewaysvalidation path. Add tests for cases whereresource.get('zones')returns 0, 1, and multiple entries to ensure correct Yes/No behavior.
if resourceSubType == "natgateways":
src/zones/azext_zones/resource_type_validators/microsoft_network.py:118
- The
publicipprefixesvalidator block is untested. Consider adding unit tests for scenarios with zero, one, and multiple zones.
if resourceSubType == "publicipprefixes":
src/zones/azext_zones/resource_type_validators/microsoft_app.py:31
- The new
jobsvalidation path lacks coverage. Add tests to verify that Container App Jobs returnDependentas expected.
if resourceSubType == "jobs":
|
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ zones-1.0.0b4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=126348429&view=results |
1.0.0b4
++++++
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az zones validate
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.